add rerank() command to the ES|QL query builder #3043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
add-rerank-esql-command
branch
from
45843a1 to
4dd1102
Compare
pquentin
approved these changes
Sep 1, 2025
elasticsearch/esql/esql.py
Outdated
Comment on lines
1146
to
1153
| f"ON {', '.join([self._format_id(field) for field in self._fields])} " | ||
| f"WITH {json.dumps(with_)}" | ||
| ) | ||
| else: | ||
| return ( | ||
| f"RERANK {json.dumps(self._query[0])} " | ||
| f"ON {', '.join([self._format_id(field) for field in self._fields])} " | ||
| f"WITH {json.dumps(with_)}" |
There was a problem hiding this comment.
nit: the code duplication makes me slightly nervous, given this code is not generated
There was a problem hiding this comment.
I thought it best to keep the templates for each version of the command separate so that you can see what the command looks like more easily, but sure, it does add some repetition. I'll see if I can come up with a better way to structure this and other similar commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.